[squeezebox] Fix local cover art download failure when auth enabled #4654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhilbush
changed the title
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/squeezebox-binding-openhab-2-5-problems/64577/43 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/squeezebox-binding-openhab-2-5-problems/64577/44 |
Signed-off-by: Mark Hilbush <[email protected]>
Signed-off-by: Mark Hilbush <[email protected]>
Signed-off-by: Mark Hilbush <[email protected]>
mhilbush
force-pushed
the
squeezebox-coverart-fix
branch
from
db4b41b to
3de238c
Compare
martinvw
approved these changes
Jan 25, 2019
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
…penhab#4654) * Fix local cover art download failure when auth enabled * Use asterisk for password display * Update known issues Signed-off-by: Mark Hilbush <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
…penhab#4654) * Fix local cover art download failure when auth enabled * Use asterisk for password display * Update known issues Signed-off-by: Mark Hilbush <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark Hilbush [email protected]
Fixes #4653
Note that there are now a number of new SAT warnings, which were not there before. I presume this is because new SAT checks were added. I will fix these in a separate PR.